mikebridge commented on PR #43779: URL: https://github.com/apache/superset/pull/43779#issuecomment-5545793054
@aminghadersohi — confirmed and fixed at the new head; your instrumentation was exact (one request, the deferred promise orphaned, the negative `waitFor` green on the first tick). The shared route now accepts a per-call function (with a comment recording the lazy-read trap for the next test author), and the race test is stateful per your sketch: call 1 returns a genuinely pending promise, call 2 the success; it asserts `landedCalls === 1` after open and `=== 2` after the newer search, then resolves the first request's 500 and flushes explicitly (`await firstPending` + a macrotask inside `act`) before a synchronous `not.toBeInTheDocument()` — no first-tick pass possible. Control re-run with your exact mutation (`const isCurrent = () => true`): **exactly the race test fails**, 45/46 pass; restored, 46/46. On the sibling `drops the note once suggestions load again`: I looked as you suggested — its first response has fully settled before the reassignment (the note is asserted on screen first), so the lazy read is harmless there; it discriminates against base (as you found) because the second request's success must clear note state. Left it on the plain reassignment, with the route comment now warning when the function form is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
