rusackas commented on PR #43575: URL: https://github.com/apache/superset/pull/43575#issuecomment-5545984771
Nice work chasing down all these edge cases, @tien238lnd, but @sadpandajoe's cycle question from a couple days ago is still open: a self-referencing layout like `ROOT_ID.children = ["ROOT_ID"]` queues the same node forever in `tabs` since there's no visited-set guard on the walk. That turns the 500 this PR fixes into a hang, which is worse. Want to add a guard for it? Their other ask would be an API-level test that stores a broken layout via `PUT` and then repairs it, also seems worth doing since that's the actual path from the issue report, not just the mocked `process_tab_diff` unit tests. Happy to jump in here if you'd like a hand with any of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
