rusackas commented on PR #43313: URL: https://github.com/apache/superset/pull/43313#issuecomment-5546203358
This is a nice, careful fix, the fallback conditions and test matrix are thorough. I'd approve it, but wondering if we need `RCA.md` checked into the repo root though? Feels like investigation notes that belong in the PR description rather than a permanent file in the tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
