rusackas commented on PR #43655: URL: https://github.com/apache/superset/pull/43655#issuecomment-5546209224
Hey @saurabhdamle11, this looks solid, the CSRF_ERROR type plus the shared refresh promise and single-retry cap match what's in #43550, and the tests cover the concurrent-refresh and give-up-after-one-replay cases well. GitHub shows conflicts with master though, so it needs a rebase before it can merge. Holler once that's sorted and I'll take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
