sadpandajoe opened a new pull request, #43919: URL: https://github.com/apache/superset/pull/43919
### SUMMARY Embedded dashboard tests only ran in the continue-on-error shadow workflow, so failures never blocked merges despite embedding being a real, required feature. This moves the Embedded Tests step into the required E2E / playwright-tests job. The subdirectory-deployment (APPLICATION_ROOT) matrix variant only ran on push in the required job, so pull requests never actually exercised it before merge. This widens it to run on every event, matching the shadow workflow's matrix. ### TESTING INSTRUCTIONS - Confirm the `E2E / playwright-tests` required job now runs both the embedded dashboard suite and the APPLICATION_ROOT matrix variant on pull_request events, and that a failure in either blocks merge. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
