sadpandajoe commented on code in PR #43902:
URL: https://github.com/apache/superset/pull/43902#discussion_r3939460566
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -555,6 +557,7 @@ All MCP settings go in `superset_config.py`. Defaults are
defined in `superset/m
| `MCP_SERVICE_URL` | `None` | Public base URL for MCP-generated
links (set this when behind a reverse proxy)
|
| `MCP_DEBUG` | `False` | Enable debug logging
|
| `MCP_DEV_USERNAME` | -- | Superset username for development
mode (no auth)
|
+| `MCP_STATELESS_HTTP` | `True` | Streamable-HTTP session mode. `True`
gives each request a fresh, ephemeral transport, torn down as soon as that
request completes; a client disconnecting mid-tool-call can crash its own
session. `False` keeps the transport alive for the session's lifetime, avoiding
that crash, but requires session-affinity routing on `Mcp-Session-Id` for
multi-pod deployments (see [Multi-Pod (Kubernetes)](#multi-pod-kubernetes)). |
Review Comment:
With the default, a client disconnect can also disconnect other concurrent
clients on that worker, not only crash its own session. Could this describe
that broader impact so operators can assess the tradeoff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
