codeant-ai-for-open-source[bot] commented on code in PR #43921:
URL: https://github.com/apache/superset/pull/43921#discussion_r3939525538
##########
superset/connectors/sqla/models.py:
##########
@@ -2355,7 +2360,8 @@ def fetch_metadata(self) -> MetadataResult:
# `columns` in the loop above, and re-adding them here (e.g. via
`old_columns`)
# would duplicate any synced physical column that also carries a truthy
# `expression`, such as Trino's expanded nested `ROW` fields.
- columns.extend([col for col in old_columns_by_name.values() if
col.expression])
+ leftover_columns = list(old_columns_by_name.values())
+ columns.extend([col for col in leftover_columns if col.expression])
Review Comment:
**Suggestion:** When a dropped physical column has an expression, this keeps
its stale `TableColumn` row and fails to bump `changed_on`, so cached charts
can use removed schema metadata. [stale reference]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=053ecbbc13734a7194bab912113ad8a7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=053ecbbc13734a7194bab912113ad8a7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/connectors/sqla/models.py
**Line:** 2363:2364
**Comment:**
*Stale Reference: When a dropped physical column has an expression,
this keeps its stale `TableColumn` row and fails to bump `changed_on`, so
cached charts can use removed schema metadata.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43921&comment_hash=6fd9bdbc1dd24513e399f4d525dbdbc508f6ee2adbeed8ccb2afe02b66a0ee97&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43921&comment_hash=6fd9bdbc1dd24513e399f4d525dbdbc508f6ee2adbeed8ccb2afe02b66a0ee97&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
