Kunal8954 commented on issue #43897: URL: https://github.com/apache/superset/issues/43897#issuecomment-5551557586
That settles it — parent is BODY, so nothing is clipping it. top: -91 means the picker is being positioned above the viewport, not cut off by a container. Also worth noting the ControlPopover itself is fine in your capture (top: 30), so the viewport-ratio placement logic I pointed at earlier isn't the culprit — it's the DatePicker's own dropdown. The DatePickers in CustomFrame pass only showTime / defaultValue / onChange / allowClear / getPopupContainer — no placement, no autoAdjustOverflow. So they get antd's defaults, which flip a popup across its trigger but don't shift it back into view. Superset already has a fix for exactly that (SHIFT_INTO_VIEWPORT in ControlPopover.tsx, with a test asserting it in DateFilterLabel.test.tsx) — but it's applied to the outer popover only, not to the pickers inside it. That also explains the zoom part: your innerHeight was 421. The showTime panel (date grid + three time columns + footer) is taller than the space left below the trigger in a viewport that short, so antd flips it upward and, with nothing shifting it back, it lands at a negative top. At 75% zoom the CSS-pixel viewport gets taller, it fits below, and looks fine. So the variable is available viewport height rather than zoom itself — which is why your DevTools-docked caveat doesn't change the conclusion, it just shortens the viewport in the same direction. On whether it's been reported before — I didn't find an issue describing this specific mechanism, though I can't rule one out. The class of problem is known in the codebase: the comment above SHIFTING_PLACEMENTS explicitly calls out popups being "stranded off screen", which is what this is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
