sadpandajoe commented on code in PR #39684:
URL: https://github.com/apache/superset/pull/39684#discussion_r3940608723
##########
superset-frontend/plugins/plugin-chart-table/src/buildQuery.ts:
##########
@@ -84,6 +87,7 @@ export const buildQuery: BuildQuery<TableChartFormData> = (
return buildQueryContext(formDataCopy, baseQueryObject => {
let { metrics, orderby = [], columns = [] } = baseQueryObject;
+ columns = columns.filter(column => !isSyntheticPercentColumn(column));
Review Comment:
This removes any real dataset/group-by column whose name begins with `%`,
not just the synthetic percent-comparison fields. A raw Table chart containing
a column such as `% change` will no longer request or display that column.
Could the synthetic fields be identified from the time-comparison metadata
instead of their display prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
