codeant-ai-for-open-source[bot] commented on code in PR #43889:
URL: https://github.com/apache/superset/pull/43889#discussion_r3941045448
##########
superset/sql_lab.py:
##########
@@ -509,9 +561,14 @@ def execute_sql_statements( # noqa: C901
cursor = conn.cursor()
cancel_query_id = db_engine_spec.get_cancel_query_id(cursor, query)
+ # Recorded unconditionally -- even when no cancel ID comes back --
+ # so cancel_query() can tell "hasn't reached the engine yet" (still
+ # safe to fabricate a stop) apart from "this engine has no cancel
+ # support" (must fail honestly) once we get here.
+ query.set_extra_json_key(QUERY_DISPATCHED_KEY, True)
if cancel_query_id is not None:
query.set_extra_json_key(QUERY_CANCEL_KEY, cancel_query_id)
- db.session.commit()
+ db.session.commit()
Review Comment:
**Suggestion:** `QUERY_DISPATCHED_KEY` is recorded before the per-block stop
check, so a stop during this gap sees no cancel ID, returns failure, and the
still-undispatched statement runs. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fc90e1bbb9314e3abbea1dd5f26c7515&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fc90e1bbb9314e3abbea1dd5f26c7515&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/sql_lab.py
**Line:** 568:571
**Comment:**
*Api Mismatch: `QUERY_DISPATCHED_KEY` is recorded before the per-block
stop check, so a stop during this gap sees no cancel ID, returns failure, and
the still-undispatched statement runs.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43889&comment_hash=83f7b1372b9163f49b3154007c88d033678f098507afe3c1072531f26ca02799&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43889&comment_hash=83f7b1372b9163f49b3154007c88d033678f098507afe3c1072531f26ca02799&reaction=dislike'>๐</a>
##########
superset/sql_lab.py:
##########
@@ -676,8 +798,24 @@ def execute_sql_statements( # noqa: C901
key,
)
- # Only set SUCCESS if we didn't already set FAILED above
- if query.status != QueryStatus.FAILED:
+ # Only set SUCCESS if we didn't already set FAILED above, and don't
+ # clobber a STOPPED status a concurrent stop request may have committed
+ # since the check above -- a terminal stop must stay terminal. This is a
+ # backstop for the DB row specifically (the payload/results-write
+ # consistency check already happened above); it doesn't reopen or
+ # re-narrow the same disclosed race window from that check.
+ #
+ # flush() first: refresh() does NOT autoflush -- without this, every
+ # result field set on the success path above (rows, progress, extra
+ # "columns", select_sql, end_time, results_key) would be silently
+ # discarded and reloaded back to their pre-execution (typically None)
+ # values on EVERY successful query, since nothing before this point
+ # commits them. This was a real regression caught by CI integration
+ # tests across all three DB backends (sqlite/mysql/postgres) that the
+ # unit-test suite driving this fix never exercised.
+ db.session.flush()
+ db.session.refresh(query)
+ if query.status not in (QueryStatus.FAILED, QueryStatus.STOPPED):
query.status = QueryStatus.SUCCESS
db.session.commit()
Review Comment:
**Suggestion:** The final check can preserve `STOPPED` in the database, but
the already-built success payload and stored results remain success data,
giving callers contradictory query state. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=41f4a756cd814bb1b56bcec1b26b4e9e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=41f4a756cd814bb1b56bcec1b26b4e9e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/sql_lab.py
**Line:** 816:820
**Comment:**
*Api Mismatch: The final check can preserve `STOPPED` in the database,
but the already-built success payload and stored results remain success data,
giving callers contradictory query state.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43889&comment_hash=68675d7d33dfc17760d95f1f6a000231e06dda0bf9a892f41d501373756fc1bc&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43889&comment_hash=68675d7d33dfc17760d95f1f6a000231e06dda0bf9a892f41d501373756fc1bc&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
