sadpandajoe commented on code in PR #43875:
URL: https://github.com/apache/superset/pull/43875#discussion_r3941850314
##########
superset/utils/cache.py:
##########
@@ -307,7 +307,7 @@ def wrapper(*args: Any, **kwargs: Any) -> Response: #
noqa: C901
wrapper.uncached = f # type: ignore
wrapper.cache_timeout = timeout # type: ignore
wrapper.make_cache_key = cache._memoize_make_cache_key( # type:
ignore # pylint: disable=protected-access
- make_name=None, timeout=timeout,
hash_method=configurable_hash_method
+ make_name=None, hash_method=configurable_hash_method
Review Comment:
This still crashes cache initialization: `etag_cache` uses `SupersetCache`,
whose `_memoize_make_cache_key` override still forwards `timeout` to
Flask-Caching 2.5 even though that parameter was removed. Should the override
be updated to stop forwarding the removed arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
