aminghadersohi opened a new pull request, #43943: URL: https://github.com/apache/superset/pull/43943
### SUMMARY Completes the Gauge MCP chart support introduced by #43568. - exposes the public `gauge` identity while retaining `gauge_chart` as a native form-data compatibility alias - round-trips the complete native Gauge control surface and preserves omitted controls on same-viz updates, while honoring explicit clears and scrubbing stale roles on viz/dataset changes - matches the frontend Gauge query builder for metric aliases, ordering, filters, temporal controls, ranges, formatting, and presentation settings - resolves dataset fields exact-first/unique-case-insensitively, rejects ambiguous references, and validates Gauge metrics/results as numeric and finite - adds Gauge-specific ASCII and Vega previews with bounded query/result errors and safe empty behavior - wires schema discovery, recommendations, examples, Explore links, data, generate, update, and cached preview paths through shared MCP abstractions Tracking: [SC-119163](https://app.shortcut.com/preset/story/119163) Original merge: #43568 Consolidated completeness request: https://github.com/apache/superset/pull/43568#issuecomment-5497059452 Coordination: this follow-up reuses the shared update/compile/error-handling direction from #43679 and #43737 where applicable, but is scoped to Gauge completeness and does not modify the Bullet, Sunburst, or contributor branches. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; this changes MCP schemas, generated form data, data/preview behavior, and validation rather than the native Explore UI. ### TESTING INSTRUCTIONS Automated validation run locally: - `449 passed` across the focused Gauge schema/plugin/compile/preview/data/generate/update/Explore/FastMCP tests - `1458 passed` across `tests/unit_tests/mcp_service/chart` and `tests/unit_tests/mcp_service/explore` - `75 passed` across `tests/unit_tests/mcp_service/common` - the full `tests/unit_tests/mcp_service` run passed except the existing environment-dependent real-ASGI health smoke test, whose local test database setup returned no version - `21 passed` across the frontend ECharts Gauge `buildQuery` and `transformProps` suites - `pre-commit run` (mypy, Ruff/format, Pylint, and repository checks) - `python -m compileall -q superset/mcp_service tests/unit_tests/mcp_service` - `git diff --cached --check` Manual/product-path coverage is included in the unit tests for saved and unsaved generate, update, cached update-preview, Explore-link, data, preview, discovery, recommendation, malformed-result, ambiguity, and dataset-rebind flows. ### ADDITIONAL INFORMATION - [x] Has associated issue: [SC-119163](https://app.shortcut.com/preset/story/119163) - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
