sadpandajoe opened a new pull request, #43948:
URL: https://github.com/apache/superset/pull/43948
### SUMMARY
Before this change, the RLS **+ Rule** Subjects picker only showed Users
because `SUBJECTS_RELATED_TYPES_RLS` had no default and fell back to the global
`SUBJECTS_RELATED_TYPES` default, which excludes `ROLE`.
This change gives the RLS-specific setting an explicit default containing
User, Role, and Group subjects. Roles are therefore selectable as RLS subjects
again, matching the pre-refactor behavior, while the unrelated global
`SUBJECTS_RELATED_TYPES` default remains untouched. The Subject configuration
documentation is updated to describe the RLS-specific default.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
This is a UI-visible picker change implemented entirely through a backend
configuration default; no frontend code changed. It was verified by the
automated regression test
`test_subject_type_filter_rls_config_default_includes_role`. A live screenshot
was not captured in this pass.
### TESTING INSTRUCTIONS
Run the updated subject-filter unit test file:
```bash
PYTHONPATH="$PWD/superset-core/src${PYTHONPATH:+:$PYTHONPATH}" pytest -q
tests/unit_tests/subjects/test_filters.py
```
Expected result: all tests pass, including
`test_subject_type_filter_rls_config_default_includes_role`, which verifies
that the RLS picker uses the explicit User/Role/Group default rather than
inheriting the global User/Group default.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
