codeant-ai-for-open-source[bot] commented on code in PR #43966:
URL: https://github.com/apache/superset/pull/43966#discussion_r3950429508
##########
superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx:
##########
@@ -328,6 +328,21 @@ export const DropdownContainer = forwardRef(
gap: ${theme.sizeUnit * 4}px;
margin-right: ${theme.sizeUnit * 4}px;
min-width: 0px;
+ /* While remeasuring after an items count change, all items are
+ * briefly mounted to measure their widths (see the layout effect
+ * below). Some browsers (e.g. Microsoft Edge) can paint that
+ * transient frame before the recalculation collapses back down,
+ * which would otherwise let this row grow past the space this
+ * component was allotted and push the dropdown trigger out of
+ * view. Clamping to the last known width keeps that frame, if
+ * painted, visually bounded instead of overflowing the bar. */
+ ${
+ recalculating &&
+ css`
+ max-width: ${width}px;
+ overflow: hidden;
Review Comment:
**Suggestion:** Consumer-provided `style` is applied inline and can override
this `max-width` or `overflow`, allowing the transient all-items row to
overflow again. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2266a0742f7241e484fd18753a9bd01d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2266a0742f7241e484fd18753a9bd01d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx
**Line:** 342:343
**Comment:**
*Api Mismatch: Consumer-provided `style` is applied inline and can
override this `max-width` or `overflow`, allowing the transient all-items row
to overflow again.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43966&comment_hash=fbdb9167aa2df2874bfa7ecf245fd90970c705f9f5e8d35ebeea7ff354d6d930&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43966&comment_hash=fbdb9167aa2df2874bfa7ecf245fd90970c705f9f5e8d35ebeea7ff354d6d930&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
