aminghadersohi commented on PR #43737: URL: https://github.com/apache/superset/pull/43737#issuecomment-5574573176
Finite follow-up to the September 7 approval and Bito issue comment #5561902836, pushed normally as 1dfd27f629a1d5961795ce3393e905e35c8d93ab. - **Mixed-timeseries ordering regression: fixed.** The secondary shared query substitutes its own `orderby_b` rather than inheriting primary `orderby`. The focused parametrized regression fails on the prior head in both cases (absent secondary ordering and explicit secondary ordering), and passes with the fix. It checks both complete query shapes and preservation of primary form-data ordering. - **Ordering key contract: clarified, not renamed.** Top-level `orderby` preserves saved query-shaped `[expression, ascending_boolean]` ordering; it is not the typed MCP `sort_by` input. Table `sort_by` maps to JSON-encoded native `order_by_cols`; typed Gantt `order_by` also maps to `order_by_cols`, which `resolve_gantt_query_fields` decodes into query `orderby`. Replacing the saved key with raw typed objects/strings would conflate distinct contracts. Existing Gantt mapping/query tests and the explicit saved-ordering regression pass. Added a concise source comment and user documentation. - **Gantt field docstring: fixed.** It documents frontend label/SQL precedence plus the native `column_name` extension; the metric resolver documents its accepted `columnName`/`column_name` objects. - **Imported filter constants: fixed.** Reused `FilterOperator.TEMPORAL_RANGE.value` and `NO_TIME_RANGE`; filter-preservation regressions pass. Prior accepted deferrals remain unchanged: strict malformed-sort rejection and the pre-existing shared dataset-validation exception policy. No new review run was requested; the PR remains open and ready for review, without rebase, force push, or merge. Validation: focused helper/Gantt/preview/cached-update suite **293 passed**; full chart suite **1,600 passed**; staged and complete PR-range pre-commit **passed**, including MyPy, Ruff, and Pylint; Python compilation and diff checks passed. Broader MCP/common-query tests and exact-head required CI are still running; I will update this comment with their final results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
