aminghadersohi commented on PR #43771: URL: https://github.com/apache/superset/pull/43771#issuecomment-5574577091
Finite disposition of Bito run #b69dc3, against the reviewed head bc8ac02f9a0dd3da8bdc3909079de1a99459efad: - **Oversized fractional Decimal identity: retained intentionally.** The digit/exponent and aggregate sampling-work limits already bound these integers. Replacing numerator/denominator with their bit lengths would merge distinct values: 11e-4096 and 13e-4096 have equal numerator/denominator bit lengths but are different fractions. Added `test_extreme_fractions_keep_distinct_exact_identities`; existing bounded-exponent/other-column regressions also pass. No production change for this suggestion. - **Terminal display width: addressed.** ASCII line clipping conservatively accounts for wide and combining Unicode characters, replaces terminal controls, and marks clipped content. Tests cover CJK, emoji, combining accents, tiny widths, and Sunburst footer preservation. - **Mutating validator name: addressed.** Renamed to `normalize_and_validate_sunburst_result_data`, updated every caller/test reference, and explicitly documented in-place NULL-to-zero normalization. Existing compile/preview/data/export NULL regressions remain passing. No additional review was requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
