sha174n opened a new pull request, #43989: URL: https://github.com/apache/superset/pull/43989
### SUMMARY `UpdateDashboardCommand.process_tab_diff` resolves the report schedules attached to a removed tab via `ReportScheduleDAO.find_by_extra_metadata`, a substring scan over `report_schedule.extra_json`. The results were used as-is, without constraining them to the dashboard being updated and without de-duplication. This scopes the lookup to the dashboard being edited (`report.dashboard_id == self._model.id`) and de-duplicates the results by id, matching the existing `process_native_filter_diff` path in the same command. Behavior for a dashboard's own tab-bound reports is unchanged. ### TESTING INSTRUCTIONS `pytest tests/unit_tests/commands/dashboard/update_test.py`. Adds a regression test asserting that a report schedule attached to a different dashboard is left untouched when a tab is removed, and updates the existing test for the scoping. ### ADDITIONAL INFORMATION - [ ] Has associated issue - [x] Required feature flags: n/a - [x] Changes UI - [ ] Includes DB Migration - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [x] Runtime consequences 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
