rusackas opened a new pull request, #43996: URL: https://github.com/apache/superset/pull/43996
### SUMMARY Resolves code-scanning alert #2661 ([zizmor/self-repository](https://github.com/apache/superset/security/code-scanning/2661)) on `.github/workflows/superset-python-integrationtest.yml:221`. The `Start Celery worker` step in the `test-sqlite` job references `.github/actions/cached-dependencies` via the workspace-relative `uses: ./...` syntax, which zizmor's `self-repository` audit flags in favor of the newer `uses: $/...` syntax. The mechanical fix doesn't apply here: `cached-dependencies` is a git submodule (see `.gitmodules`), and `$/...` resolves action files directly from the repository tree without performing a real, submodule-aware checkout, so it can't see past the submodule's gitlink into the actual `action.yml`. This mirrors the same documented false-positive pattern already used for this action elsewhere in the repo (`superset-translations.yml`, `superset-python-presto-hive.yml`), using the same explanatory comment and the same `# zizmor: ignore[self-repository]` trailing-comment placement (required because zizmor's comment-placement rule for this audit needs the suppression to fall within the flagged `uses:` value's span). Only this one occurrence (line 221, alert #2661) is touched; the file's other `self-repository` findings (alerts #2652, #2653, #2654, #2655, #2656, #2657, #2658, #2659, #2660) are tracked as separate, already-open alerts and are out of scope for this PR. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — CI workflow YAML only, no UI change. ### TESTING INSTRUCTIONS - `zizmor .github/workflows/superset-python-integrationtest.yml` (v1.30.0, matching the version pinned in `.pre-commit-config.yaml`) no longer reports a `self-repository` finding for line 221 (now shows as ignored instead of a live finding). - `pre-commit run --files .github/workflows/superset-python-integrationtest.yml` passes, including the `zizmor` hook. - Workflow runtime behavior is unchanged; only a trailing comment was added. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API Resolves code-scanning alert #2661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
