codeant-ai-for-open-source[bot] commented on code in PR #44000:
URL: https://github.com/apache/superset/pull/44000#discussion_r3958843665
##########
superset/commands/database/update.py:
##########
@@ -114,9 +121,64 @@ def run(self) -> Model:
).run()
except (OAuth2RedirectError, MissingOAuth2TokenError):
pass
+ except DatabaseConnectionFailedError:
+ if not can_skip_failed_sync:
+ raise
+ logger.warning(
+ "Skipping permission sync for database %s: connection
unavailable "
+ "and connection settings unchanged",
+ self._model_id,
+ )
return database
+ def _can_skip_failed_sync(self) -> bool:
+ """Check that the connection and permission identity remain
unchanged."""
+ assert self._model
+
+ connection_fields = {
+ "database_name", # Schema and catalog permissions include this
name.
+ "sqlalchemy_uri",
+ "encrypted_extra",
+ "extra",
+ "server_cert",
+ "impersonate_user",
+ "ssh_tunnel",
+ }
+ for key in connection_fields & self._properties.keys():
+ incoming = self._properties[key]
+ original = getattr(self._model, key)
+ if key == "sqlalchemy_uri":
+ try:
+ original =
make_url_safe(self._model.sqlalchemy_uri_decrypted)
+ except Exception:
+ # An unavailable old password store must not block repairs.
+ return False
+ incoming = make_url_safe(incoming.strip())
+ if incoming.password == PASSWORD_MASK:
+ incoming = incoming.set(password=original.password)
+ elif key in {"extra", "encrypted_extra"}:
+ try:
+ original = json.loads(original or "{}")
+ incoming = json.loads(incoming or "{}")
+ except json.JSONDecodeError:
+ return False
+ elif key == "server_cert":
+ original = original or None
+ incoming = incoming or None
+ elif key == "ssh_tunnel" and original is not None and incoming is
not None:
+ incoming = unmask_password_info(incoming.copy(), original)
+ incoming = {
+ field: incoming.get(field) for field in
original.export_fields
+ }
+ original = {
+ field: getattr(original, field) for field in
original.export_fields
+ }
Review Comment:
**Suggestion:** Full connection payloads omit load-only SSH credentials, so
this comparison turns them into `None` and treats unchanged tunnels as changed,
preventing offline metadata updates. [logic error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4de7f863063b4d819ab487db83f20aa3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4de7f863063b4d819ab487db83f20aa3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/database/update.py
**Line:** 171:176
**Comment:**
*Logic Error: Full connection payloads omit load-only SSH credentials,
so this comparison turns them into `None` and treats unchanged tunnels as
changed, preventing offline metadata updates.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44000&comment_hash=02bc84403cdc6737e9c08a0e13f52f69f5b217e9d7ffe2d5f8c0b5d76c986ab1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44000&comment_hash=02bc84403cdc6737e9c08a0e13f52f69f5b217e9d7ffe2d5f8c0b5d76c986ab1&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
