rusackas opened a new pull request, #44001: URL: https://github.com/apache/superset/pull/44001
### SUMMARY The `superset-docs-preview` Netlify deploy preview has been failing on essentially every open PR — including ones that don't touch `docs/` at all (e.g. #43961, #43963) — for two independent, unrelated-to-the-PR-content reasons: 1. **Stale hardcoded Node version.** `docs/netlify.toml` hardcoded `NODE_VERSION = "20"` (with a comment claiming it matched `docs/.nvmrc`). The repo standardized on Node 24 a while back (#40835, #41500), and `docs/.nvmrc` is already a symlink to the single source of truth at `superset-frontend/.nvmrc` (same pattern used by `superset-websocket/.nvmrc` and `superset-embedded-sdk/.nvmrc`) — but nobody updated the Netlify override to match, so it silently drifted to Node 20. That was merely stale until a transitive dependency (`[email protected]`, pulled in via `docusaurus-theme-openapi-docs`) started requiring Node `>=22.11.0`. Yarn 1 hard-fails `yarn install` on an engine mismatch by default, so every deploy preview died at install time: ``` error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 22.11.0". Got "20.20.2" ``` Fix: drop the hardcoded `NODE_VERSION` and let Netlify auto-detect it from `docs/.nvmrc`, so this can't drift again. 2. **`@ant-design/icons` / `@ant-design/icons-svg` version mismatch.** `@ant-design/icons` was bumped to `6.3.3` by dependabot (#43951), which imports icon assets (e.g. `MetaFilled`, `NetflixFilled`) that only exist starting in `@ant-design/[email protected]`. Its own declared dependency range (`^4.5.0`) still let yarn resolve to the older `4.5.0`, so once install succeeded (after fix #1), the webpack build failed: ``` Module not found: Can't resolve '@ant-design/icons-svg/es/asn/MetaFilled' ``` Fix: pin `@ant-design/icons-svg` to `^4.6.0` via the existing `resolutions` block (same pattern already used for several other transitive pins in `docs/package.json`). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — CI/build config and lockfile only. ### TESTING INSTRUCTIONS - Verified locally under Node 24.17.0 (matching `docs/.nvmrc` → `superset-frontend/.nvmrc`): - `yarn install` completes with no engine errors. - `yarn build` completes with `[SUCCESS] Generated static files in "build"` and a populated `docs/build/` directory. - Confirmed via `git log` that this Node/dependency drift, not PR content, is the actual cause: 7 of 8 sampled currently-open PRs fail the identical `superset-docs-preview` checks, including a docs-only PR (#43973). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
