mistercrunch commented on a change in pull request #8536: Pass url parameters
from dashboard to charts
URL:
https://github.com/apache/incubator-superset/pull/8536#discussion_r348313724
##########
File path: superset/views/core.py
##########
@@ -2192,13 +2192,19 @@ def dashboard(**kwargs):
"slice_can_edit": slice_can_edit,
}
)
+ url_params = {
+ key: value
+ for key, value in request.args.items()
+ if key not in ("edit", "standalone")
Review comment:
The blacklisting here seems brittle. Wondering if it's necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
