sadpandajoe commented on code in PR #43757:
URL: https://github.com/apache/superset/pull/43757#discussion_r3960284172


##########
docs/static/feature-flags.json:
##########
@@ -81,6 +81,12 @@
         "lifecycle": "development",
         "description": "Try to optimize SQL queries \u2014 for now only 
predicate pushdown is supported"
       },
+      {
+        "name": "PARTITION_FILTER_MAPPING",
+        "default": false,
+        "lifecycle": "development",
+        "description": "Mirror filters on a dataset's business column onto its 
physical partition column, so engines that require an explicit partition 
predicate can prune."

Review Comment:
   Enabling this documented flag currently cannot mirror any filters: this 
change only stores and serializes mapping metadata, and no query consumer has 
been added. Should the description say it enables configuration and validation 
until the rewrite exists?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to