gabotorresruiz commented on PR #40297: URL: https://github.com/apache/superset/pull/40297#issuecomment-5589926670
Hi @BansonVuong, thanks for digging into this one, and sorry it sat in the queue so long. Your root cause analysis (the constrained parent container defeating antd's flip logic) is exactly right. In the meantime #40032 merged in June and fixed #34135 in this same spot: it mounts the dashboard filter dropdown under `document.body` by default and only keeps the parent container for the filter config modal and overflow cases. I ran the Select plugin suite at current master and its regression test asserts the dropdown is portaled to `document.body`, so the fix is covered there; that is also why this branch now conflicts in `SelectFilterPlugin.tsx`. One thing worth flagging since the review threads touched on it: the dashboard filter bar never passes `appSection` into the plugin (only the filter config modal sets it), so the `AppSection.Dashboard`/`AppSection.FilterBar` branch here would not have fired at runtime. The merged fix sidesteps that by defaulting to `document.body`, and its test renders the real component and asserts the portal target, which is the pattern that catches unwired props where pure helper tests cannot. Given all that I think the kindest path is to close this one as superseded. The investigation was solid and the conclusion matched where master landed, so please read this as timing, nothing more. If you spot the overlap still reproducing on current master, or want to pick up another native filters issue, happy to dig in with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
