aminghadersohi commented on PR #43943: URL: https://github.com/apache/superset/pull/43943#issuecomment-5593117426
Addressed the optional XLSX item in [the approving review](https://github.com/apache/superset/pull/43943#pullrequestreview-5146726270) in `dfeb3922517376e51e7ccacecfefab6965beda48`. - The default openpyxl exporter writes non-finite floats as `nan`, `inf`, and `-inf` text, matching CSV. NULL remains blank and finite values remain numeric; no rows or raw query values are changed. - Six public FastMCP XLSX cases failed before the fix and pass afterward: saved, saved-with-form-data-key, and unsaved requests, each with mixed/all-non-finite groups. Tests load the actual exported workbook and assert cell values, not just row presence. - Resolved the master conflict with a normal merge (`f8962a5`), retaining the upstream shared rejected-filter helper and this PR's query-error checks. No rebase or force-push. - All prior review dispositions remain covered, including the [preceding five-item pass](https://github.com/apache/superset/pull/43943#issuecomment-5591302722). The four existing inline threads remain resolved; the approving review has no new inline thread to resolve. Validation: **1,816 affected Python tests**, **21 frontend Gauge tests**, **12 rendered specs**, full branch-applicable/staged pre-commit including mypy, compileall, and optimized-mode renderability checks passed. **All 13 required checks passed on this exact head**, including [unit tests](https://github.com/apache/superset/actions/runs/34286545612/job/102271644763), [PostgreSQL integration](https://github.com/apache/superset/actions/runs/34286545666/job/102270047968), [Playwright](https://github.com/apache/superset/actions/runs/34286545649/job/102267917438), [pre-commit](https://github.com/apache/superset/actions/runs/34286545519/job/102263356710). PR body testing/coordination sections are updated. No additional review is requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
