rusackas commented on PR #38119: URL: https://github.com/apache/superset/pull/38119#issuecomment-5593758623
@Vansh5632 scratch what I said last time, I was wrong to call @SBIN2010's point moot. It's not about where the options live, it's about the underlying rendering, ECharts supports all these positions per its own docs, and the diff still drops 8 of them here. If that's right, the real fix is probably narrower, maybe just `inside` being reversed as @SBIN2010 suggested, not removing working options. Also, existing saved charts using one of the removed positions will hit a blank Label position dropdown now, nothing here migrates the old value. Needs another pass before this is mergeable, sorry for the whiplash on the comment thread. I'm doing my best, but losing my marbles with all the reviews around here :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
