rusackas commented on PR #38069: URL: https://github.com/apache/superset/pull/38069#issuecomment-5593750451
Looking again at this. You did a nice job pulling the two older attempts together, but I don't think this is *actually* mergeable as-is. Changing `postForm` from positional args to a single config object is a breaking change for anyone still calling it the old way, it'll silently no-op instead of throwing. Copilot flagged that back in March and @sadpandajoe asked about keeping a deprecated positional overload in August, but neither's been answered yet. Also still conflicting with `master`, and CodeQL plus pre-commit are both red on the latest run. Probably worth settling the API question before we get into the rebase... I can't push commits here, so we'll need your help to move it forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
