rusackas commented on PR #43000: URL: https://github.com/apache/superset/pull/43000#issuecomment-5594451887
Thanks @s1ny1998, the rebase and CI are all sorted, and the staging swap looks like the right shape. One thing before I approve, though. I'd like @aminghadersohi's `append` finding fixed here rather than in a follow-up, since it's the same crash this round just closed, only on the other strategy. If you can add that (the `DESCRIBE TABLE` approach seems right to me), I'm happy to re-review and stamp. Almost there! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
