tien238lnd commented on PR #43994: URL: https://github.com/apache/superset/pull/43994#issuecomment-5595236093
Reporter of #43987 here — thanks for picking this up. I applied the branch on a local instance and it does fix everything the issue describes: `schema_access` and `catalog_access` holders can now explore a query they didn't author, and I saw no over-granting in the negative cases I tried. Two things I'd still flag. A regression test would be worth it — this path already broke once, in #36245, which is how we ended up here. And the new `database` guard may not cover every way a `Query` reaches `can_access_schema()` with its database relationship unset; happy to share the specifics if that's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
