codeant-ai-for-open-source[bot] commented on code in PR #43950:
URL: https://github.com/apache/superset/pull/43950#discussion_r3964514964
##########
superset/commands/database/importers/v1/utils.py:
##########
@@ -118,6 +129,15 @@ def import_database( # noqa: C901
existing =
db.session.query(Database).filter_by(uuid=config["uuid"]).first()
if existing:
if not overwrite or not can_write:
+ if can_write:
+ # Chart/dataset/saved-query/dashboard bundles that reference
+ # an already-imported database reach this branch; without
+ # this, a schema added to the live connection since the
+ # database was first imported would never get a first-time
+ # grant through this path either. ``add_permissions()`` does
+ # a live, uncached metadata scan, so this can be slow for
+ # cross-catalog-enabled engines -- see its own comment.
+ _sync_permissions_best_effort(existing)
Review Comment:
**Suggestion:** Existing bundle imports now perform catalog discovery, but
non-connection database errors raised there escape this wrapper and fail
imports that previously returned the database. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=580021d6341844148f19f2782c020319&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=580021d6341844148f19f2782c020319&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/database/importers/v1/utils.py
**Line:** 140:140
**Comment:**
*Api Mismatch: Existing bundle imports now perform catalog discovery,
but non-connection database errors raised there escape this wrapper and fail
imports that previously returned the database.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43950&comment_hash=dddc69570b5ddadc4b299fa80b737dbf4c76bfaea1af01c38ed9fa675a16dd92&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43950&comment_hash=dddc69570b5ddadc4b299fa80b737dbf4c76bfaea1af01c38ed9fa675a16dd92&reaction=dislike'>๐</a>
##########
superset/commands/database/utils.py:
##########
@@ -51,6 +51,25 @@ def ping(engine: Engine) -> bool:
return engine.dialect.do_ping(conn)
+def _get_all_schema_names_with_retry(
+ database: Database, catalog: str | None
+) -> set[str]:
+ """
+ Retry the live schema-listing call once before giving up on a catalog.
+
+ Some catalogs are visible but not listable (eg the ``rdsadmin`` catalog on
+ AWS RDS), but the exception caught by the caller doesn't distinguish that
+ from a one-off transient hiccup (eg schema metadata not yet visible right
+ after it was created). A single retry lets a schema that needs a
+ first-time grant survive a fluke without tolerating a persistently
+ unlistable catalog for any longer than before.
+ """
+ try:
+ return database.get_all_schema_names(catalog=catalog, cache=False)
+ except GenericDBException: # pylint: disable=broad-except
+ return database.get_all_schema_names(catalog=catalog, cache=False)
Review Comment:
**Suggestion:** This catches `OAuth2RedirectError` because
`GenericDBException` aliases `Exception`, so one schema lookup can start the
OAuth redirect twice. [possible bug]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b0bd853db32c436ca8ee27934ff5625e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b0bd853db32c436ca8ee27934ff5625e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/database/utils.py
**Line:** 69:70
**Comment:**
*Possible Bug: This catches `OAuth2RedirectError` because
`GenericDBException` aliases `Exception`, so one schema lookup can start the
OAuth redirect twice.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43950&comment_hash=376148321a8ad4b52ab92d0489a25c39680819ae40fe3a220a3d46b7e12dbd46&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43950&comment_hash=376148321a8ad4b52ab92d0489a25c39680819ae40fe3a220a3d46b7e12dbd46&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
