I3eka commented on PR #43278: URL: https://github.com/apache/superset/pull/43278#issuecomment-5596531526
@justinpark, refreshed the branch onto master c76e4d98 (head 6f1e7516), and traced the September 6 SQL Lab Playwright failure to a real issue in this PR. The saved network trace in [run 34033301163](https://github.com/apache/superset/actions/runs/34033301163) shows GET /api/v1/database/?q=(filters:!((col:id,opr:eq,value:1)),page:0,page_size:1) returning HTTP 400: `Filter column: id not allowed to filter`. The list API does not allow that filter, so migration never reached POST /tabstateview/. The fix uses the existing GET /api/v1/database/{id} resource endpoint. Only 404 clears the unavailable database selection; 400/403/500 and network failures keep the local state and retry behavior. The updated endpoint regression fails before the fix. After it: `82 passed, 1 skipped`, and all applicable pre-commit hooks pass, including frontend type checking. The PR still changes only the SQL Lab action and its test. Could you review this updated head when convenient? The previous E2E result is not a green result for this fix; the newly triggered CI still needs to validate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
