amaannawab923 commented on code in PR #43769:
URL: https://github.com/apache/superset/pull/43769#discussion_r3967298918
##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -47,6 +47,7 @@ import {
getThemeController,
} from './EmbeddedContextProviders';
import { embeddedApi } from './api';
+import EmbeddedChart from './embeddedChart';
Review Comment:
Done, following `LazyDashboardPage` exactly — `lazy(() =>
import('./embeddedChart'))` with its own `webpackChunkName`. It renders inside
the `Suspense` boundary that component already sits in, so no new boundary was
needed.
The split is real rather than just structural: the build now emits
`EmbeddedChart.<hash>.chunk.js` separately, and in a dev build that chunk is
3.2M against a 384K `embedded` entry. Dashboard-only consumers no longer pay
for any of it.
##########
superset/migrations/versions/2026-09-01_10-00_a1c7e4b62f18_add_embedded_charts_table.py:
##########
@@ -0,0 +1,53 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""add embedded_charts table
+
+Revision ID: a1c7e4b62f18
+Revises: 39097d124752
Review Comment:
Both fixed. The docstring now matches, and the chain points at
`7e2c9a4f1b83`.
The mismatch turned out to be the more interesting half: the migration and
`b3e9c1a75d24` both claimed `8f31c5d726ab` as their parent, which is what left
two heads and produced the conflict. Thanks for running it up and down — that
saved a round trip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
