Ujjwaljain16 commented on PR #43985: URL: https://github.com/apache/superset/pull/43985#issuecomment-5600875313
as per bito code review: i traced both paths more closely the `executor.py` schema resolution isn't used by the SQL Lab -> Create Chart flow; the relevant chart path uses the same `self.schema / get_default_schema()` resolution as this cache-key change, so i couldn't reproduce a mismatch for performance, this mirrors the existing `SqlaTable` behavior and is only called once per cache-key computation. i would avoid memoization here for now since RLS predicates are user/role-dependent and live so am leaving both unchanged for this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
