no-hup commented on PR #43990: URL: https://github.com/apache/superset/pull/43990#issuecomment-5601295171
One correction to what I said above, since you raised the 1,000-chart case and my number doesn't hold there. I said the count stays at 3. That's only true inside the first `selectinload` batch. It batches its own IN list at 500, so each relationship adds a statement per 500 charts. Measured on the branch: | charts | statements | |---|---| | 3 | 3 | | 25 | 3 | | 600 | 5 | | 1200 | 7 | So it's `1 + 2 * ceil(N / 500)`, not constant. Still 7 against 2400 for a 1,200-chart dashboard, and the outer query is one bind parameter at every size, so your portability point is fully addressed — but "constant-query contract" was the wrong words and my test name said it too. Renamed it and wrote the batching into the docstring in 4f7abee. Nothing else changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
