Piyush-08-bot commented on issue #44079: URL: https://github.com/apache/superset/issues/44079#issuecomment-5605250716
@rusackas @squalou — I dug into this regression and traced it back to the `BigInt()` call in `parseResponse.ts` from the #44044 fix. It converts large integers to native JS `bigint`, which then causes `JSON.stringify` to throw in a few downstream paths (ag-Grid/FilterableTable, sorting, clipboard copy, etc.). I see two ways to handle it: 1. Keep `bigint` and add guards at each consumer. 2. Stop creating native `bigint` in `parseResponse.ts` and keep large values as decimal strings instead — this also preserves full precision, which `Number()` conversion would lose. I'm leaning toward the second option since it fixes the issue at the source and avoids having to handle `bigint` separately across multiple consumers. Since this is directly related to #44044, wanted to get your thoughts before I start changing several files. @Piyush-08-bot since this builds on your fix. Happy to share the findings/diff if helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
