villebro opened a new pull request, #44100:
URL: https://github.com/apache/superset/pull/44100

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   
   The plain apache/superset tags (latest, master, <version>, per-SHA) were 
built from the lean stage, which ships no database drivers, no browser, and no 
MCP support — the image wasn't usable until you layered your own drivers. This 
makes the default image batteries-included instead.
   
   A new FROM lean AS superset stage bundles the common metadata/analytics 
drivers (psycopg2-binary, mysqlclient), the MCP server dependencies (fastmcp), 
and a headless Chromium via Playwright for Alerts & Reports / thumbnails. It 
stays non-root and byte-compiled — it is not the dev stage (which keeps its 
root access, git, and editable install for local development). Chromium ships 
for both linux/amd64 and linux/arm64, so multi-platform builds are unaffected.
   
   The previous minimal image is still published, now under -lean tags 
(latest-lean, master-lean, <version>-lean). This adds the superset preset to 
the build matrices in docker.yml, tag-release.yml, and 
scheduled-docker-image-refresh.yml, wires it into the pyver-override-check and 
WebSocket smoke test, points docker-compose-image-tag.yml at the plain latest 
tag, and updates docs/admin_docs/installation/docker-builds.mdx and UPDATING.md.
   
   Note: the actual preset→published-tag mapping lives in the external 
apache-superset/supersetbot repo and must be updated there in tandem — 
repointing the plain tags to the new superset preset (target stage superset) 
and giving lean the -lean suffix. This PR only adds the superset preset name to 
the matrices; the mapping change is a companion supersetbot change.
   
   TESTING INSTRUCTIONS
   
   - docker build --target superset -t superset:test . then verify drivers and 
browser: docker run --rm superset:test python -c "import psycopg2, MySQLdb, 
mcp", docker run --rm superset:test playwright --version, and docker run --rm 
superset:test bash -lc 'id -u' (non-root).
   - Confirm --target lean still lacks the drivers (additions didn't leak into 
python-common/lean).
   - Multi-arch: docker buildx build --platform linux/arm64 --target superset 
... and launch Chromium under arm64.
   - pre-commit run --files on the changed workflows/Dockerfile/docs (passes 
locally).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to