gabotorresruiz commented on PR #44022: URL: https://github.com/apache/superset/pull/44022#issuecomment-5609361897
@aminghadersohi thanks for the careful pass. All three addressed in \`f613dcb\` (replies inline on each thread, now resolved): - **form_data_key-only gap**: that branch now calls \`_attach_active_filters\` after redaction, so a forwarded filter plus time range surfaces under \`active_filters\`/\`active_time_range\` instead of reading as unfiltered. Pinned by \`test_unsaved_chart_surfaces_active_filters\`. - **Preview coverage**: \`test_extra_form_data_filters_reach_preview_query\` is parametrized over \`table\`/\`ascii\`/\`vega_lite\`, asserting on the captured query context so removing the forwarding in any strategy fails. - **active_filters description**: reworded to include adhoc filters (and aligned the \`_attach_active_filters\` docstring). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
