sadpandajoe commented on code in PR #36350:
URL: https://github.com/apache/superset/pull/36350#discussion_r3973524275
##########
superset/common/query_context_processor.py:
##########
@@ -219,15 +279,17 @@ def query_cache_key(self, query_obj: QueryObject,
**kwargs: Any) -> str | None:
)
return cache_key
- def get_query_result(self, query_object: QueryObject) -> QueryResult:
+ def get_query_result(
+ self, query_object: QueryObject, query: Query | None = None
+ ) -> QueryResult:
"""
Returns a pandas dataframe based on the query object.
This method delegates to the datasource's get_query_result method,
which handles query execution, normalization, time offsets, and
post-processing.
"""
- return self._qc_datasource.get_query_result(query_object)
+ return self._qc_datasource.get_query_result(query_object, query=query)
Review Comment:
Agreed—the current call still passes `query=` to
`SemanticView.get_query_result()`, which only accepts `query_object`, so every
semantic-view chart raises `TypeError` before rendering. Could this retain the
tracking argument only for datasources that support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
