rusackas commented on PR #43821: URL: https://github.com/apache/superset/pull/43821#issuecomment-5611957332
The root-plus-exclusions encoding is the right fix for the tab-id-anchoring bug, but I think it breaks display. `useFilterScope.ts` picks the tab-list vs flat-chart-list branch off `rootPath[0] === DASHBOARD_ROOT_ID`, and that's now always true once any chart is excluded, so a filter scoped to a whole tab renders as a pile of chart names instead of the tab label. Can you also take a look at the three open Copilot comments on utils.ts (the `as number` cast, non-deterministic `excluded` ordering, and the new `describe` block) and fix the failing pre-commit check, looks like oxfmt just needs to run on the test file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
