codeant-ai-for-open-source[bot] commented on code in PR #44127: URL: https://github.com/apache/superset/pull/44127#discussion_r3975101984
########## docs/docs/using-superset/exploring-data.mdx: ########## @@ -165,6 +165,16 @@ control can override a simple metric's own aggregation (to Sum or Average) for t only โ metrics built from custom SQL keep their own aggregation regardless. ::: +In the **Options** panel, the **Show values as** control displays each cell as a percentage of its +row total, column total, or grand total instead of its actual value: + +:::note +Totals and subtotals are still computed correctly first, as described above; **Show values as** +only changes how the already-correct cell, row-total, column-total, and grand-total values are +displayed. Because the result is always a percentage, a per-metric custom formatter (currency, +decimal precision, etc.) doesn't apply while a fraction option is selected. Review Comment: **Suggestion:** Changing this control can trigger extra database rollup queries, including for hidden totals, so describing it as display-only hides its query and failure impact. [logic error] **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5e0ce612c67545e6a0c738be586adb7f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5e0ce612c67545e6a0c738be586adb7f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/docs/using-superset/exploring-data.mdx **Line:** 173:175 **Comment:** *Logic Error: Changing this control can trigger extra database rollup queries, including for hidden totals, so describing it as display-only hides its query and failure impact. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44127&comment_hash=e13ba5fd0fa0df24191682fd2d4665fd87168083ffa2b843f2ebdfbab3db7987&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44127&comment_hash=e13ba5fd0fa0df24191682fd2d4665fd87168083ffa2b843f2ebdfbab3db7987&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
