bito-code-review[bot] commented on PR #44130:
URL: https://github.com/apache/superset/pull/44130#issuecomment-5612123106
<!-- Bito Reply -->
The flagged issue is correct. The tools `list_metrics`, `get_table`,
`get_compatible_dimensions`, and `get_compatible_metrics` interact with both
built-in datasets and external semantic views, requiring additional permissions
beyond `can_read` on `Dataset`.
To resolve this, update the documentation table in
`docs/admin_docs/configuration/mcp-server.mdx` to reflect the broader
permission requirements.
```markdown
-| `list_metrics`, `get_table`, `get_compatible_dimensions`,
`get_compatible_metrics` | `can_read` on `Dataset`
|
+| `list_metrics`, `get_table`, `get_compatible_dimensions`,
`get_compatible_metrics` | `can_read` on `Dataset`
(read), `can_read` on `SemanticView` (read) |
```
There are no other comments on this PR to address. Would you like me to
proceed with this update?
**docs/admin_docs/configuration/mcp-server.mdx**
```
| `list_metrics`, `get_table`, `get_compatible_dimensions`,
`get_compatible_metrics` | `can_read` on `Dataset`
(read), `can_read` on `SemanticView` (read) |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
