rusackas commented on PR #43536: URL: https://github.com/apache/superset/pull/43536#issuecomment-5612358524
This has gone silent, so I'll make some touchups to help move it along. Codeant's backward-compat point seems real - renaming the PVM to `UserInfo` means custom roles holding the old grant won't pick up the new one automatically, so folks could lose Settings → Info access after upgrade. Might need a migration or compat check instead of a straight rename. Also, sadpandajoe's right that the new test only checks decorator metadata and role PVM membership, not an actual authenticated request hitting `/user_info/`. Could you add a Gamma/Alpha client test asserting a 200? Pre-commit's also red, just a one-line ruff autofix (B009) - easy fix, I reckon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
