rusackas commented on PR #43457: URL: https://github.com/apache/superset/pull/43457#issuecomment-5612532229
@varadendrasimha511 thanks for digging into this! One thing before this goes further, though. #43481 landed on `master` after this was opened and went the other way on purpose: totals stay out of the color scale because they're sums of the very cells being shaded and wash everything else out. Also, the renderer never calls `getCellColor` on the `pvtTotal` cells, so widening the domain wouldn't color those grand totals anyway. If the goal is coloring the totals cells, I think that's a renderer change rather than a scale change... curious your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
