sadpandajoe commented on code in PR #44131:
URL: https://github.com/apache/superset/pull/44131#discussion_r3975965704
##########
.github/workflows/superset-docs-deploy.yml:
##########
@@ -190,7 +190,7 @@ jobs:
run: .github/workflows/scripts/check-docs-deploy-freshness.sh
- name: deploy docs
if: github.event_name == 'workflow_dispatch' ||
steps.recheck-freshness.outputs.still-current == 'true'
- uses: ./.github/actions/github-action-push-to-another-repository
+ uses: $/.github/actions/github-action-push-to-another-repository
Review Comment:
This action is a git submodule, so the self-repository download contains
only its gitlink and cannot find `action.yml`; because this workflow runs only
after master/dispatch, docs deployment will first break after merge. Should
this stay workspace-relative with the recursive checkout, as the other
submodule-backed actions do?
##########
.github/workflows/scheduled-docker-image-refresh.yml:
##########
@@ -119,7 +119,7 @@ jobs:
sparse-checkout: .github/actions
- name: Setup Docker Environment
- uses: ./workflow-source/.github/actions/setup-docker
+ uses: $/workflow-source/.github/actions/setup-docker
Review Comment:
`$/` resolves against the repository tree, so it cannot see the
`workflow-source` directory created by the preceding checkout; the next
scheduled image refresh will fail before building any of its six variants, and
the existing workflow regression test is already failing on this change. Should
these two references stay workspace-relative (or drop the `workflow-source/`
prefix if the extra checkout is removed)?
##########
.github/workflows/superset-e2e.yml:
##########
@@ -114,13 +114,13 @@ jobs:
submodules: recursive
# -------------------------------------------------------
- name: Setup Python
- uses: ./.github/actions/setup-backend/
+ uses: $/.github/actions/setup-backend/
- name: Setup postgres
- uses: ./.github/actions/cached-dependencies
+ uses: $/.github/actions/cached-dependencies
Review Comment:
Agreed—the current head's E2E and Superset App CLI jobs already fail during
action preparation because the repository tree contains only the
`cached-dependencies` gitlink, so the recursive checkout never gets a chance to
provide `action.yml`. Can these submodule-backed references stay
workspace-relative with the existing zizmor suppression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
