beatum commented on PR #43705: URL: https://github.com/apache/superset/pull/43705#issuecomment-5613949957
> Thanks for fixing the service-worker COPY. Couple of things since though: it's showing conflicts against `master` now, and the Netlify docs check is failing. Also, the Dockerfile itself lost its `BUILDPLATFORM` arg and `--platform` pin as part of this diff, that looks unrelated to the Podman work and could affect multi-arch builds. Can you rebase and confirm that was intentional? Thank you. Here is my latest update: Rebased master onto origin/master and restored the Dockerfile to match the upstream version. Confirmed that removing BUILDPLATFORM and --platform was intentional. Commit 7575af60c6 (fix(docker): remove unnecessary BUILDPLATFORM argument from Dockerfile) introduced this change. Identified an unstaged local change in package-lock.json as the cause of the earlier conflict. I have left the change uncommitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
