bito-code-review[bot] commented on code in PR #43215:
URL: https://github.com/apache/superset/pull/43215#discussion_r3976499973
##########
superset-frontend/src/views/routes.tsx:
##########
@@ -32,161 +28,161 @@ import { RoutePaths } from './routePaths';
// not lazy loaded since this is the home page.
import Home from 'src/pages/Home';
-const ChartCreation = lazy(
+const ChartCreation = lazyWithRetry(
() =>
import(/* webpackChunkName: "ChartCreation" */ 'src/pages/ChartCreation'),
);
-const AnnotationLayerList = lazy(
+const AnnotationLayerList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "AnnotationLayerList" */
'src/pages/AnnotationLayerList'
),
);
-const AlertReportList = lazy(
+const AlertReportList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "AlertReportList" */ 'src/pages/AlertReportList'
),
);
-const AnnotationList = lazy(
+const AnnotationList = lazyWithRetry(
() =>
import(/* webpackChunkName: "AnnotationList" */
'src/pages/AnnotationList'),
);
-const ChartList = lazy(
+const ChartList = lazyWithRetry(
() => import(/* webpackChunkName: "ChartList" */ 'src/pages/ChartList'),
);
-const ArchivedList = lazy(
+const ArchivedList = lazyWithRetry(
() => import(/* webpackChunkName: "ArchivedList" */
'src/pages/ArchivedList'),
);
-const CssTemplateList = lazy(
+const CssTemplateList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "CssTemplateList" */ 'src/pages/CssTemplateList'
),
);
-const ThemeList = lazy(
+const ThemeList = lazyWithRetry(
() => import(/* webpackChunkName: "ThemeList" */ 'src/pages/ThemeList'),
);
-const DashboardList = lazy(
+const DashboardList = lazyWithRetry(
() =>
import(/* webpackChunkName: "DashboardList" */ 'src/pages/DashboardList'),
);
-const Dashboard = lazy(
+const Dashboard = lazyWithRetry(
() => import(/* webpackChunkName: "Dashboard" */ 'src/pages/Dashboard'),
);
-const DatabaseList = lazy(
+const DatabaseList = lazyWithRetry(
() => import(/* webpackChunkName: "DatabaseList" */
'src/pages/DatabaseList'),
);
-const DatasetList = lazy(
+const DatasetList = lazyWithRetry(
() => import(/* webpackChunkName: "DatasetList" */ 'src/pages/DatasetList'),
);
-const DatasetCreation = lazy(
+const DatasetCreation = lazyWithRetry(
() =>
import(
/* webpackChunkName: "DatasetCreation" */ 'src/pages/DatasetCreation'
),
);
-const ExecutionLogList = lazy(
+const ExecutionLogList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "ExecutionLogList" */ 'src/pages/ExecutionLogList'
),
);
-const Chart = lazy(
+const Chart = lazyWithRetry(
() => import(/* webpackChunkName: "Chart" */ 'src/pages/Chart'),
);
-const QueryHistoryList = lazy(
+const QueryHistoryList = lazyWithRetry(
() =>
import(
/* webpackChunkName: "QueryHistoryList" */ 'src/pages/QueryHistoryList'
),
);
-const SavedQueryList = lazy(
+const SavedQueryList = lazyWithRetry(
() =>
import(/* webpackChunkName: "SavedQueryList" */
'src/pages/SavedQueryList'),
);
-const SqlLab = lazy(
+const SqlLab = lazyWithRetry(
() => import(/* webpackChunkName: "SqlLab" */ 'src/pages/SqlLab'),
);
-const AllEntities = lazy(
+const AllEntities = lazyWithRetry(
() => import(/* webpackChunkName: "AllEntities" */ 'src/pages/AllEntities'),
);
-const Tags = lazy(
+const Tags = lazyWithRetry(
() => import(/* webpackChunkName: "Tags" */ 'src/pages/Tags'),
);
-const Extensions = lazy(
+const Extensions = lazyWithRetry(
() => import(/* webpackChunkName: "Tags" */ 'src/extensions/ExtensionsList'),
Review Comment:
<!-- Bito Reply -->
The update to the webpack chunk name for the Extensions route is
appropriate. It resolves the duplicate chunk name issue identified in the
review, ensuring that the Extensions module is correctly isolated from the Tags
module for better cache management.
**superset-frontend/src/views/routes.tsx**
```
-const Extensions = lazy(
+const Extensions = lazyWithRetry(
- () => import(/* webpackChunkName: "Tags" */
'src/extensions/ExtensionsList'),
+ () => import(/* webpackChunkName: "Extensions" */
'src/extensions/ExtensionsList'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
