denys1204 commented on PR #42842: URL: https://github.com/apache/superset/pull/42842#issuecomment-5616404967
Rebased onto master, though the notebook part had to be redone by hand rather than replayed. The Madagascar unique-ISO change that landed on master today rewrote the generator notebook (11 MB down to 225 KB), and `.ipynb` is marked binary here, so nothing auto-merges. Same three edits as before: the Malawi markdown and code cells after Kenya, `"malawi": malawi_copy` in `alt_maps`, and the one-line relabel in the checked-in geojson. Side note that backs up your first review: that same commit re-ran the notebook and re-committed the country geojsons, and `malawi.geojson` came out with the duplicate `MW-CT` still in it. So a geojson-only fix really would have been reverted today. On the red checks, none of them came from this diff. They all died in `Set up job` on Aug 17 with codeload 503/429 while downloading actions (codeql-action, dependency-review-action, actions-timeline, cache-apt-pkgs-action). Fresh run is going now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
