rusackas commented on code in PR #44124:
URL: https://github.com/apache/superset/pull/44124#discussion_r3982784759
##########
scripts/docker-build-extra-flags.sh:
##########
@@ -42,7 +42,7 @@ IMAGE_TAG="${2:?usage: docker-build-extra-flags.sh
<build_preset> <image_tag>}"
EXTRA_FLAGS="--build-arg INCLUDE_CHROMIUM=false --tag $IMAGE_TAG"
if [ "$BUILD_PRESET" != "py311" ] && [ "$BUILD_PRESET" != "py312" ]; then
- EXTRA_FLAGS="--build-arg PY_VER=3.11.14-slim-trixie $EXTRA_FLAGS"
+ EXTRA_FLAGS="--build-arg PY_VER=3.11.16-slim-trixie $EXTRA_FLAGS"
Review Comment:
Good catch, fixed! Both workflows now pull the `--build-arg PY_VER` override
from `docker-build-extra-flags.sh` too, so release and refresh builds stop
falling back to supersetbot's own `3.10-slim-bookworm` default.
##########
docker/apt-install.sh:
##########
@@ -38,6 +38,14 @@ RESET='\033[0m'
echo -e "${GREEN}Updating package lists...${RESET}"
apt-get update -qq
+# The base image's already-installed packages can lag behind the latest
+# point release available in its own configured repos between rebuilds of
+# that image tag. Applying available updates at build time, not just
+# whatever shipped with the base image, keeps every already-installed
+# package current too, not only the ones this call adds.
+echo -e "${GREEN}Applying available package updates...${RESET}"
+apt-get upgrade -yqq
Review Comment:
I don't think this holds up. BuildKit's cache-from lookups chain off the
resolved `FROM` digest, and CI spins up a fresh buildx builder each run, so a
moved base tag already busts the cached apt-install layer without any extra
invalidation needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
