EnxDev commented on PR #44082: URL: https://github.com/apache/superset/pull/44082#issuecomment-5615202380
Thanks for flagging `row_limit: 0`. I traced it through the chart-data query path. `QueryObjectFactory._process_row_limit()` calls `apply_max_row_limit(row_limit or default_row_limit, ...)`, so zero, null, and a missing value all become the configured `ROW_LIMIT` before the query runs. Keeping the same fallback in the sync budget matches that behavior; treating zero as unbounded here would make the estimate disagree with execution. I clarified the docstring, and the unit test covers all three cases. I also fixed the failed guest integration test in `32a4229842`. The test temporarily grants the Public role route-level export permission so the request reaches the explicit `GuestUser` guard, then restores the original role state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
