bito-code-review[bot] commented on code in PR #43236:
URL: https://github.com/apache/superset/pull/43236#discussion_r3983066869
##########
superset/db_engine_specs/db2.py:
##########
@@ -57,7 +57,8 @@ class Db2EngineSpec(BaseEngineSpec):
"connection_string":
"ibm_db_sa://{username}:{password}@{hostname}:{port}/{database}",
"is_recommended": False,
"notes": (
- "Use for older DB2 versions without LIMIT [n] syntax. "
+ "Db2 11.1.0 or higher is required to support SQL
compatibility enhancements."
+ "Use for older Db2 versions without LIMIT [n] syntax. "
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing space in notes</b></div>
<div id="fix">
The two adjacent string literals concatenate without a separator, so the
user-facing driver notes render as "...SQL compatibility enhancements.Use for
older Db2 versions...". Add a trailing space to line 60 (e.g. `enhancements.
"`) so the two sentences are readable.
</div>
</div>
<small><i>Code Review Run #184fb2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
