ShauryaaIBM commented on code in PR #43762: URL: https://github.com/apache/superset/pull/43762#discussion_r3986786807
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -28,6 +28,130 @@ Dashboard reports and alerts are limited to the PDF and PNG formats; the CSV, XL For alerts (not scheduled reports), PNG/PDF screenshots and chart CSV/XLSX data are only generated when the `ALERTS_ATTACH_REPORTS` [feature flag](/admin-docs/configuration/configuring-superset#feature-flags) is enabled (the default); with it disabled, an alert notification is still sent, but without the attachment. +## Browser-Print PDF for Dashboards + +By default, dashboard PDF reports are produced by stitching raster screenshots. Enabling the `DASHBOARD_REPORTS_BROWSER_PRINT_PDF` [feature flag](/admin-docs/configuration/feature-flags) switches dashboard PDF reports to Playwright's native `page.pdf()`, which produces vector PDFs with selectable text. + +### Prerequisites + +- The `PLAYWRIGHT_REPORTS_AND_THUMBNAILS` [feature flag](/admin-docs/configuration/feature-flags) must also be enabled (Playwright must be installed and working). +- This path is dashboard-only. Chart PDF reports always use the screenshot path regardless of this flag. Review Comment: Fixed in commit `7ce60553`. Added a bolded bullet to the **Prerequisites** section: > **Multi-tab reports via `ALERT_REPORT_TABS` are not supported.** When a report targets a dashboard spread across multiple permalink URLs (i.e. `ALERT_REPORT_TABS` is enabled and more than one tab is selected), `_get_browser_print_pdf` returns `None` and the report falls back to the raster screenshot path even when this flag is enabled. Single-URL dashboard reports (including dashboards with tabs navigated via hash fragments) are fully supported. This matches the limitation already captured in `UPDATING.md` and surfaces it to operators before they enable the flag, so they aren't surprised when multi-tab reports continue producing raster output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
